Replace string concatenation with StringBuilder and invariant interpolation#696
Open
kamilla11 wants to merge 1 commit into
Open
Replace string concatenation with StringBuilder and invariant interpolation#696kamilla11 wants to merge 1 commit into
kamilla11 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThis PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an ChangesInterpolated String Handler Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
I also want to warn you that IDE0055 errors occurred during the build, which are not present in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes issue #648.
StringExtensions.AppendInvariant(StringBuilder, …)as a single cross-TFM API.InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
Refactor
Chores